Added recipe for the Prooph pack #320

gquemener · 2018-03-19T10:49:26Z

Q	A
License	MIT

Initial conversation is here

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

This reverts commit 41dca24.

ghost

Pull request passes validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

Nyholm · 2018-03-20T17:53:40Z

Let me know when you are ready for a review

Nyholm

I would suggest updating travis.yml in a separate PR.

@gquemener could you address my other comments?

Nyholm · 2018-06-16T08:36:41Z

.travis.yml

@@ -25,4 +27,4 @@ install:
    - composer config extra.symfony.allow-contrib true

 script:
-    - composer req "${PACKAGES}"
+    - composer req $(echo "$PACKAGES" | tr --delete '\n')


Sorry for not being clear. $PACKAGES will never contain more that one package.

gquemener · 2018-06-16T11:00:42Z

Ok, for handling the travis configuration in a separate PR.

I'm taking care of your other comments, thanks.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

gquemener · 2018-06-19T19:07:01Z

It's done @Nyholm, thanks for your comments 👍

ramondelafuente · 2018-06-19T19:59:41Z

👍 Yay!

Nyholm

Thank you. Im happy with this PR. I left a small comment that you could fix if you want to.

I've tested this PR locally and it works great. To make sure it get merged, remove "WIP" from the title.

Nyholm · 2018-06-22T16:47:20Z

prooph/pdo-event-store/1.7/config/packages/prooph_pdo_event_store.yaml

+    app.event_store.pdo_connection.mysql:
+        class: \PDO
+        arguments:
+            - 'mysql:host=%env(MYSQL_HOST)%;dbname=%env(MYSQL_DBNAME)%'


You could use a environment variable like "MSQL_DSN" here instead.

Nyholm · 2018-07-07T10:06:39Z

Any updates here?

kochen · 2018-07-10T08:05:43Z

The php doc seems to answer no to this question: http://php.net/manual/en/ref.pdo-mysql.connection.php (it might be worth trying it though).

This indeed seems to be the case.

The factory method is a good idea indeed, but creates a dependency with the Doctrine bundle.

Then it's not worth fixing at the moment.

I suggest we go with what you have now and it needed/require we can always improve it later.

ramondelafuente · 2018-08-08T18:06:25Z

It looks like everyone in this thread is happy at this point... Is there anything else blocking this now? Or maybe it's a release cycle that it's waiting on? (just asking)

gquemener · 2018-09-28T18:58:57Z

Hello 👋

Considering this summer announcement¹ about dropping support on the prooph/service-bus package, I'd say this PR would need to be reworked before merged...

Any thought @UFOMelkor @codeliner?

Should it be simply closed?

¹ here and here

prolic · 2018-09-29T05:46:34Z

No, it's still supported for a while and used a lot.

…

On Sat, Sep 29, 2018, 02:59 Gildas Quéméner ***@***.***> wrote: Hello 👋 Considering this summer announcement1 about dropping support on the prooph/service-bus package, I'd say this PR would need to be reworked before merged... Any thought @UFOMelkor <https://github.com/UFOMelkor> @codeliner <https://github.com/codeliner>? Should it be simply closed? ------------------------------ 1 here <https://www.sasaprolic.com/2018/08/the-future-of-prooph-components.html> and here <https://www.sasaprolic.com/2018/08/the-future-of-prooph-components.html> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#320 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvFObk_9MholJD4nwKEFmtfPpG1CRks5ufnF0gaJpZM4Sv8L1> .

codeliner · 2018-09-30T14:41:03Z

What @prolic said + the next service bus version could be a community driven project using symfony messenger but adding CQRS semantics on top of it. A future prooph pack could provide that. Anyway, service-bus is maintained until 31.12.2019.

OskarStark · 2018-10-29T07:16:48Z

So IIRC this one is ready to merge?

EDIT:
I mean from the recipe point of view (Travis needs to be fixed before ofc)

fabpot · 2018-10-29T07:28:15Z

If that's the case, then the WIP in the title must be removed.

gquemener · 2018-10-29T08:15:23Z

Travis is failing because this PR contains recipes for many packages at the same time. I had provided a solution, but @Nyholm asked me to revert it.

I am not sure what to do to fix the build then 🤔, would you have a suggestion @OskarStark ?

I'm removing the WIP flag

ghost

Pull request passes validation.

OskarStark · 2018-10-29T09:48:41Z

Nice 👍

EDIT:
Oh this one was merged automatically, without a green travis build 🤔 @Nyholm can you please have a look at this?

@gquemener sorry, I missed your question. @Nyholm can you elaborate on this commit? as @gquemener said that there is more than one package in $PACKAGES ❓

OskarStark · 2018-10-29T10:18:15Z

The problem with travis could be, that you submitted many recipes in one PR and travis expects only one recipe per PR?

gquemener · 2018-10-29T11:02:43Z

The problem with travis could be, that you submitted many recipes in one PR and travis expects only one recipe per PR?

Yes it is. The $PACKAGES var will contain "new line" delimited packages list which composer require don't understand (it needs a space delimited packages list).

I managed to get this space delimited list by using composer req $(echo "$PACKAGES" | tr --delete '\n')

Added recipe for prooph/service-bus-symfony-bundle

ff73795

ghost suggested changes Mar 19, 2018

View reviewed changes

gquemener mentioned this pull request Mar 19, 2018

Symfony Flex Recipe prooph/service-bus-symfony-bundle#41

Open

ghost suggested changes Mar 19, 2018

View reviewed changes

Fixed invalid versionning

1d6cb4b

ghost suggested changes Mar 19, 2018

View reviewed changes

Register ProophServiceBusBundle

1d495c0

ghost suggested changes Mar 19, 2018

View reviewed changes

ghost deployed to staging March 19, 2018 11:09 View deployment

ghost approved these changes Mar 19, 2018

View reviewed changes

ghost deployed to staging March 19, 2018 11:09 View deployment

ghost approved these changes Mar 19, 2018

View reviewed changes

Autowired default command bus

a3e37cc

ghost deployed to staging March 19, 2018 12:31 View deployment

ghost approved these changes Mar 19, 2018

View reviewed changes

Auto-register command handlers

41dca24

ghost deployed to staging March 19, 2018 13:57 View deployment

ghost approved these changes Mar 19, 2018

View reviewed changes

Revert "Auto-register command handlers"

9e9d069

This reverts commit 41dca24.

ghost deployed to staging March 19, 2018 14:02 View deployment

ghost approved these changes Mar 19, 2018

View reviewed changes

Defined recipe for the prooph pack

2fde35c

ghost suggested changes Mar 20, 2018

View reviewed changes

Defined prooph service bus bundle default config

17a7249

ghost deployed to staging March 20, 2018 17:51 View deployment

ghost approved these changes Mar 20, 2018

View reviewed changes

Autowired command handlers

26ec16d

ghost deployed to staging March 20, 2018 17:55 View deployment

Nyholm requested changes Jun 16, 2018

View reviewed changes

Reverted travis multi packages support

838f441

ghost deployed to staging June 19, 2018 18:45 View deployment

ghost approved these changes Jun 19, 2018

View reviewed changes

Removed comments from config files

47394ca

ghost deployed to staging June 19, 2018 19:05 View deployment

ghost approved these changes Jun 19, 2018

View reviewed changes

Nyholm approved these changes Jun 22, 2018

View reviewed changes

Reduced number of env vars

245e200

tgalopin approved these changes Sep 28, 2018

View reviewed changes

gquemener changed the title ~~[WIP] Added recipe for the Prooph pack~~ Added recipe for the Prooph pack Oct 29, 2018

ghost deployed to staging October 29, 2018 08:15 View deployment

ghost approved these changes Oct 29, 2018

View reviewed changes

ghost merged commit 245e200 into symfony:master Oct 29, 2018

ghost pushed a commit that referenced this pull request Oct 29, 2018

Merge pull request #320

d9ac529

This pull request was closed.

Added recipe for the Prooph pack #320

Added recipe for the Prooph pack #320

Conversation

gquemener commented Mar 19, 2018 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Nyholm commented Mar 20, 2018

Nyholm left a comment

Choose a reason for hiding this comment

Nyholm Jun 16, 2018

Choose a reason for hiding this comment

gquemener commented Jun 16, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

gquemener commented Jun 19, 2018

ramondelafuente commented Jun 19, 2018

Nyholm left a comment

Choose a reason for hiding this comment

Nyholm Jun 22, 2018

Choose a reason for hiding this comment

Nyholm commented Jul 7, 2018

kochen commented Jul 10, 2018

ramondelafuente commented Aug 8, 2018

gquemener commented Sep 28, 2018 • edited Loading

prolic commented Sep 29, 2018 via email

codeliner commented Sep 30, 2018

OskarStark commented Oct 29, 2018 • edited Loading

fabpot commented Oct 29, 2018

gquemener commented Oct 29, 2018

ghost left a comment

Choose a reason for hiding this comment

OskarStark commented Oct 29, 2018 • edited Loading

OskarStark commented Oct 29, 2018

gquemener commented Oct 29, 2018

gquemener commented Mar 19, 2018 •

edited

Loading

gquemener commented Sep 28, 2018 •

edited

Loading

OskarStark commented Oct 29, 2018 •

edited

Loading

OskarStark commented Oct 29, 2018 •

edited

Loading